From 90456e54a42604909bf2d93cb74abbbf6574268f Mon Sep 17 00:00:00 2001 From: Katayama Hirofumi MZ Date: Fri, 14 Aug 2020 23:40:10 +0900 Subject: [PATCH] [APPWIZ] Don't hung up in Gecko download cancellation #3049 Do not call EndDialog outside the dialog procedure. CORE-14538 --- dll/cpl/appwiz/addons.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dll/cpl/appwiz/addons.c b/dll/cpl/appwiz/addons.c index 238348d0dce..32e29f9a46f 100644 --- a/dll/cpl/appwiz/addons.c +++ b/dll/cpl/appwiz/addons.c @@ -59,7 +59,7 @@ static const addon_info_t addons_info[] = { static const addon_info_t *addon; static HWND install_dialog = NULL; -static IBinding *download_binding; +static IBinding *download_binding = NULL; static WCHAR GeckoUrl[] = L"https://svn.reactos.org/amine/wine_gecko-2.40-x86.msi"; @@ -382,7 +382,7 @@ static DWORD WINAPI download_proc(PVOID arg) } DeleteFileW(tmp_file); - EndDialog(install_dialog, 0); + PostMessageW(install_dialog, WM_COMMAND, IDCANCEL, 0); return 0; }