From 863203030f2c2f485613fec1555d260f96888485 Mon Sep 17 00:00:00 2001 From: Katayama Hirofumi MZ Date: Mon, 30 Mar 2026 04:39:26 +0900 Subject: [PATCH] [IMM32][SDK] Rename CLIENTIMC_UNKNOWN2 as CLIENTIMC_LOCKED (#8807) Improve code readability. JIRA issue: CORE-19268 - Rename CLIENTIMC_UNKNOWN2 flag as CLIENTIMC_LOCKED. - Delete unused CLIENTIMC_UNKNOWN4 flag. - Fix the return value of Imm32AssignNewLayout function. --- sdk/include/reactos/imm32_undoc.h | 3 +-- win32ss/user/imm32/imm.c | 6 +++--- win32ss/user/imm32/install.c | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/sdk/include/reactos/imm32_undoc.h b/sdk/include/reactos/imm32_undoc.h index e08c9ca7842..5897579654a 100644 --- a/sdk/include/reactos/imm32_undoc.h +++ b/sdk/include/reactos/imm32_undoc.h @@ -170,10 +170,9 @@ C_ASSERT(sizeof(CLIENTIMC) == 0x34); /* flags for CLIENTIMC */ #define CLIENTIMC_WIDE 0x1 #define CLIENTIMC_ACTIVE 0x2 -#define CLIENTIMC_UNKNOWN4 0x20 #define CLIENTIMC_DESTROY 0x40 #define CLIENTIMC_DISABLEIME 0x80 -#define CLIENTIMC_UNKNOWN2 0x100 +#define CLIENTIMC_LOCKED 0x100 PCLIENTIMC WINAPI ImmLockClientImc(_In_ HIMC hImc); VOID WINAPI ImmUnlockClientImc(_Inout_ PCLIENTIMC pClientImc); diff --git a/win32ss/user/imm32/imm.c b/win32ss/user/imm32/imm.c index b45080cf558..4a220a37d26 100644 --- a/win32ss/user/imm32/imm.c +++ b/win32ss/user/imm32/imm.c @@ -690,9 +690,9 @@ Imm32DestroyInputContext(HIMC hIMC, HKL hKL, BOOL bKeep) goto Finish; } - if ((pClientImc->dwFlags & CLIENTIMC_UNKNOWN2) && !bKeep) + if ((pClientImc->dwFlags & CLIENTIMC_LOCKED) && !bKeep) { - ERR("Can't destroy for CLIENTIMC_UNKNOWN2\n"); + ERR("Can't destroy for CLIENTIMC_LOCKED\n"); return FALSE; } @@ -988,7 +988,7 @@ ImmLockClientImc(_In_ HIMC hImc) return NULL; } - pClientImc->dwFlags |= CLIENTIMC_UNKNOWN2; + pClientImc->dwFlags |= CLIENTIMC_LOCKED; Finish: InterlockedIncrement(&pClientImc->cLockObj); diff --git a/win32ss/user/imm32/install.c b/win32ss/user/imm32/install.c index a7e3e6dd06e..37e9ff4e0c0 100644 --- a/win32ss/user/imm32/install.c +++ b/win32ss/user/imm32/install.c @@ -175,7 +175,7 @@ Imm32AssignNewLayout( } } - return (HKL)LongToHandle(MAKELONG(wLangID, nID)); + return UlongToHandle(MAKELONG(wLangID, nID)); } static UINT