From 840dfdc3a112f2f5bb968cd8e32650fdda320b94 Mon Sep 17 00:00:00 2001 From: Timo Kreuzer Date: Tue, 19 Sep 2023 04:15:02 +0300 Subject: [PATCH] [CRT] Add parameter check to _mbscmp Fixes crash in msvcrt_winetest::string --- sdk/lib/crt/mbstring/mbscmp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sdk/lib/crt/mbstring/mbscmp.c b/sdk/lib/crt/mbstring/mbscmp.c index 611d086cc45..8f93a5fc838 100644 --- a/sdk/lib/crt/mbstring/mbscmp.c +++ b/sdk/lib/crt/mbstring/mbscmp.c @@ -1,10 +1,14 @@ #include #include +#include /* * @implemented */ int _mbscmp(const unsigned char *str1, const unsigned char *str2) { + if (!MSVCRT_CHECK_PMT(str1 && str2)) + return _NLSCMPERROR; + return strcmp((const char*)str1, (char*)str2); }