From 3ebb6cc7a013f078024eae0f10b5196fecae9a2f Mon Sep 17 00:00:00 2001 From: Thomas Sankey Date: Thu, 5 Nov 2026 11:42:52 +0000 Subject: [PATCH] [RAPPS] Tell the invisible window not to grab the keyboard (#9744) When silently installing RAPPS apps, it is possible to press the space bar and this passes an invisible key press to cancel, thus making the program not install. The proposed fix tells the invisible window not to grab the keyboard. CORE-20816 Co-authored-by: Claude Opus 5.5 --- base/applications/rapps/loaddlg.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/base/applications/rapps/loaddlg.cpp b/base/applications/rapps/loaddlg.cpp index 76db5da09db..10ef1fea574 100644 --- a/base/applications/rapps/loaddlg.cpp +++ b/base/applications/rapps/loaddlg.cpp @@ -805,7 +805,10 @@ CDownloadManager::RealDlgProc(HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lParam ShowWindow(hDlg, IsSilentDialog() ? SW_HIDE : SW_SHOW); StartWorkerThread(); - return TRUE; + // A silent dialog is never shown, so it must not take the keyboard focus. + // Otherwise the focus goes to the hidden Cancel button and keys typed into + // another window (e.g. a space in the console) cancel the download (CORE-20816). + return !IsSilentDialog(); } case WM_COMMAND: