From 3cddd76f57130581f691d8936f38ee3ac8a2dc91 Mon Sep 17 00:00:00 2001 From: Timo Kreuzer Date: Wed, 21 Aug 2024 11:05:09 +0300 Subject: [PATCH] [RTL] Fix overflow case in vDbgPrintExWithPrefixInternal The string should always be NULL terminated. --- sdk/lib/rtl/debug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sdk/lib/rtl/debug.c b/sdk/lib/rtl/debug.c index 3c0be055496..f9e9c192295 100644 --- a/sdk/lib/rtl/debug.c +++ b/sdk/lib/rtl/debug.c @@ -102,10 +102,11 @@ vDbgPrintExWithPrefixInternal(IN PCCH Prefix, if (Length == MAXULONG) { /* Terminate it if we went over-board */ - Buffer[sizeof(Buffer) - 1] = '\n'; + Buffer[sizeof(Buffer) - 2] = '\n'; + Buffer[sizeof(Buffer) - 1] = '\0'; /* Put maximum */ - Length = sizeof(Buffer); + Length = sizeof(Buffer) - 1; } else {