From 30dcc229f06f395e55f3f94df5db310afdf56a42 Mon Sep 17 00:00:00 2001 From: Joachim Henze Date: Mon, 30 Mar 2020 17:18:16 +0200 Subject: [PATCH] [ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code Just to satisfy static code analysis. No change in behavior expected. The same way as the external applications maintainers fixed it in their latest version https://sourceforge.net/projects/pice/files/pICE%20source/build_20/ By killing the whole function ScrollUp() with the disabled code. Like the original authors I left the functions unused declaration existing within hardware.h --- .../sysutils/utils/pice/module/hardware.c | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c b/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c index 65864a0373e..7d49b793eda 100644 --- a/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c +++ b/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c @@ -664,27 +664,6 @@ void ClrLine(ULONG line) ohandlers.ClrLine(line); } -//************************************************************************* -// ScrollUp() -// -// Scroll a specific window up one line -//************************************************************************* -void ScrollUp(USHORT Window) -{ - USHORT i; - - return; - - if(!wWindow[Window].bScrollDisabled) - { - for(i=1;i=wWindow[Window].cy) { wWindow[Window].usCurY=wWindow[Window].cy-1; - ScrollUp(Window); } if(wWindow[Window].bScrollDisabled==TRUE)break; }