From 2c57d695da7dbed5f8144e82cda92e8092d6d014 Mon Sep 17 00:00:00 2001
From: Alex Mendoza <05alex.mendozaa@gmail.com>
Date: Sun, 29 Mar 2026 21:35:48 +0200
Subject: [PATCH] [NETSHELL] Fix buffer size parameter (#8802)

Change szFormat to szBuffer in StrFormatByteSizeW calls.
Using szFormat is incorrect and could cause buffer overflow if buffer sizes differ.
---
 dll/shellext/netshell/lanstatusui.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dll/shellext/netshell/lanstatusui.cpp b/dll/shellext/netshell/lanstatusui.cpp
index 471d0fb4e38..a88d4f84ebc 100644
--- a/dll/shellext/netshell/lanstatusui.cpp
+++ b/dll/shellext/netshell/lanstatusui.cpp
@@ -70,12 +70,12 @@ UpdateLanStatusUiDlg(
         }
     }
 
-    if (StrFormatByteSizeW(IfEntry->dwInOctets, szBuffer, sizeof(szFormat)/sizeof(WCHAR)))
+    if (StrFormatByteSizeW(IfEntry->dwInOctets, szBuffer, _countof(szBuffer)))
     {
         SendDlgItemMessageW(hwndDlg, IDC_RECEIVED, WM_SETTEXT, 0, (LPARAM)szBuffer);
     }
 
-    if (StrFormatByteSizeW(IfEntry->dwOutOctets, szBuffer, sizeof(szFormat)/sizeof(WCHAR)))
+    if (StrFormatByteSizeW(IfEntry->dwOutOctets, szBuffer, _countof(szBuffer)))
     {
         SendDlgItemMessageW(hwndDlg, IDC_SEND, WM_SETTEXT, 0, (LPARAM)szBuffer);
     }