From 20e23bbfcdcc1bb4efc3b0a92bbd3053c5eb9c6f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?=
 <hermes.belusca-maito@reactos.org>
Date: Fri, 21 Jan 2022 17:09:53 +0100
Subject: [PATCH] [NTOS:EX] ExpGet/SetCurrentUserUILanguage() take pointer to
 const string. Add an implementation note to NtQueryDefaultUILanguage().

---
 ntoskrnl/ex/locale.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/ntoskrnl/ex/locale.c b/ntoskrnl/ex/locale.c
index 9e0f57aa458..b8abb886031 100644
--- a/ntoskrnl/ex/locale.c
+++ b/ntoskrnl/ex/locale.c
@@ -21,14 +21,14 @@ LCID PsDefaultSystemLocaleId = 0x00000409;
 LANGID PsInstallUILanguageId = LANGIDFROMLCID(0x00000409);
 
 /* UI/Thread IDs: Same as system */
-LANGID PsDefaultUILanguageId = 0x00000409;
-LCID PsDefaultThreadLocaleId = LANGIDFROMLCID(0x00000409);
+LCID PsDefaultThreadLocaleId = 0x00000409;
+LANGID PsDefaultUILanguageId = LANGIDFROMLCID(0x00000409);
 
 /* PRIVATE FUNCTIONS *********************************************************/
 
 NTSTATUS
 NTAPI
-ExpGetCurrentUserUILanguage(IN PWSTR MuiName,
+ExpGetCurrentUserUILanguage(IN PCWSTR MuiName,
                             OUT LANGID* LanguageId)
 {
     UCHAR ValueBuffer[256];
@@ -101,7 +101,7 @@ ExpGetCurrentUserUILanguage(IN PWSTR MuiName,
 
 NTSTATUS
 NTAPI
-ExpSetCurrentUserUILanguage(IN PWSTR MuiName,
+ExpSetCurrentUserUILanguage(IN PCWSTR MuiName,
                             IN LANGID LanguageId)
 {
     OBJECT_ATTRIBUTES ObjectAttributes;
@@ -426,6 +426,7 @@ NtQueryDefaultUILanguage(OUT LANGID* LanguageId)
         else
         {
             /* Failed, use fallback value */
+            // NOTE: Windows doesn't use PsDefaultUILanguageId.
             *LanguageId = PsInstallUILanguageId;
         }
     }