mirror of
https://github.com/Yeachan-Heo/oh-my-claudecode.git
synced 2026-09-02 22:14:43 +08:00
54fd3eb2ff
Follow-up to PR #3068 anti-slop sweep. Seven findings addressed: - Delete duplicate cleanup-readiness scaffolding under .omx/plans/source-overall-cleanup/ (4 prefixed drafts superseded by un-prefixed canonical siblings). - find-node.sh: capture the absolute node path from `command -v` instead of storing the bare string "node", so step 2 honors the script's promise to bypass PATH at exec time. - Consolidate the deprecated-MCP-provider predicate: export isDeprecatedMcpProvider and DEPRECATED_MCP_PROVIDER_WARNING from the delegation-routing barrel and consume from src/config/loader.ts, so the codex/gemini compatibility rule has one source of truth. - Replace the regex-literal-reparse hook-portability test in plugin-setup-deps with four behavior tests that exercise the actual patching rules against in-memory inputs. - Remove the stray empty .tmp-post-tool-use-failure-tests/ directory and add .tmp-*/ to .gitignore so prefix-variant temp dirs are ignored. - Reconcile competing pattern-numbering comments in plugin-setup.mjs. - Note in src/config/loader.ts that TEAM_ROLE_PROVIDERS contains /team CLI worker providers, not the deprecated MCP delegationRouting. Constraint: preserve all PR #3068 behavior; this pass is consolidation and hygiene only. Constraint: loader.ts deprecation log text must stay verbatim (two config tests pin the substring). Rejected: subprocess-based plugin-setup test | hooksJsonPath is hard coded relative to the script and would mutate the real repo file. Rejected: importing the patcher into the test | plugin-setup.mjs has no patcher export; refactoring it was out of scope for an anti-slop pass. Confidence: high Scope-risk: narrow Directive: F5's behavior test mirrors plugin-setup.mjs patching logic inline. If you change the patching rules in plugin-setup.mjs, update the inline patchCommand helper in plugin-setup-deps.test.ts to match — the test will not auto-detect drift. Not-tested: full-suite vitest had one unrelated flake in src/team/__tests__/rebase-smoke.test.ts (waitForEventInLog timeout under load); passes 6/6 in isolation, no slop-cleanup change touches src/team/. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>