Files
ironclaw/scripts/ci/test_changed_workspace_packages.py
Henry Park b63333f9a7 ci: scope merge queue to affected areas (#7898)
* ci: scope merge queue to affected areas

* fix(ci): close merge-group scope gaps

* Address PR review feedback (#7898)

- make workspace manifests exhaustive in merge-group scope

- resolve renamed reverse-dependency edges

- shallow-fetch merge-group diff endpoints

- restore the established Windows Clippy target scope

* Address PR review feedback (#7898)

- preserve uncapped canonical crate buckets for merge-group runs
- execute PR and merge-group shell diff branches in regression coverage
- pin the affected-package selector CLI JSON contract

* Address PR review feedback (#7898)

- keep CLI subprocess fixtures portable across Windows and POSIX

---------

Co-authored-by: Henry Park <16583448+henrypark133@users.noreply.github.com>
2026-08-27 16:50:10 +00:00

269 lines
9.0 KiB
Python

#!/usr/bin/env python3
"""Contracts for changed production-package selection."""
from __future__ import annotations
import importlib.util
import json
import subprocess
import sys
import tempfile
import unittest
from pathlib import Path
ROOT = Path(__file__).resolve().parents[2]
MODULE = ROOT / "scripts/ci/changed_workspace_packages.py"
SPEC = importlib.util.spec_from_file_location("changed_workspace_packages", MODULE)
assert SPEC is not None and SPEC.loader is not None
selector = importlib.util.module_from_spec(SPEC)
sys.modules[SPEC.name] = selector
SPEC.loader.exec_module(selector)
def metadata() -> dict:
return {
"workspace_members": ["root", "alpha", "nested"],
"packages": [
{
"id": "root",
"name": "root",
"manifest_path": str(ROOT / "Cargo.toml"),
"dependencies": [{"name": "nested"}],
},
{
"id": "alpha",
"name": "alpha",
"manifest_path": str(ROOT / "crates/alpha/Cargo.toml"),
"dependencies": [],
},
{
"id": "nested",
"name": "nested",
"manifest_path": str(ROOT / "crates/family/nested/Cargo.toml"),
"dependencies": [{"name": "alpha"}],
},
],
}
def metadata_with_renamed_workspace_dependency() -> dict:
data = metadata()
data["packages"][0]["dependencies"] = [
{
"name": "nested",
"rename": "renamed-nested",
"path": str(ROOT / "crates/family/nested"),
}
]
return data
class ChangedWorkspacePackagesTests(unittest.TestCase):
def run_cli(
self, changed_paths: list[str], event: str
) -> subprocess.CompletedProcess[str]:
with tempfile.TemporaryDirectory() as temp_dir:
changed_files = Path(temp_dir) / "changed-files.txt"
changed_files.write_text("\n".join(changed_paths), encoding="utf-8")
return subprocess.run(
[
sys.executable,
str(MODULE),
"--event",
event,
"--changed-files",
str(changed_files),
],
cwd=ROOT,
capture_output=True,
text=True,
check=False,
)
def test_cli_prints_exact_scope_schema(self) -> None:
scenarios = (
(
"selected",
"pull_request",
["crates/contracts/ironclaw_common/src/lib.rs"],
{"mode": "selected", "packages": ["ironclaw_common"]},
),
(
"full",
"merge_group",
["Cargo.lock"],
{"mode": "full", "packages": []},
),
(
"none",
"pull_request",
["docs/using/cli.mdx"],
{"mode": "none", "packages": []},
),
)
for name, event, changed_paths, expected in scenarios:
with self.subTest(name=name):
result = self.run_cli(changed_paths, event)
self.assertEqual(result.returncode, 0, result.stderr)
self.assertEqual(json.loads(result.stdout), expected)
def test_cli_fails_fast_for_empty_merge_group_diff(self) -> None:
result = self.run_cli([], "merge_group")
self.assertNotEqual(result.returncode, 0)
self.assertIn("empty merge-group diff", result.stderr)
def test_selects_direct_production_packages(self) -> None:
self.assertEqual(
selector.changed_production_packages(
["crates/alpha/src/lib.rs", "crates/family/nested/build.rs"],
metadata(),
),
["alpha", "nested"],
)
def test_test_and_ci_only_changes_do_not_launch_clippy(self) -> None:
self.assertEqual(
selector.changed_production_packages(
[
"crates/alpha/tests/contract.rs",
".github/workflows/code_style.yml",
],
metadata(),
),
[],
)
def test_crate_manifest_selects_its_package(self) -> None:
self.assertEqual(
selector.changed_production_packages(
["crates/alpha/Cargo.toml"],
metadata(),
),
["alpha"],
)
def test_workspace_manifest_or_lockfile_selects_the_full_workspace(self) -> None:
for path in ("Cargo.toml", "Cargo.lock"):
with self.subTest(path=path):
self.assertEqual(
selector.changed_production_packages([path], metadata()),
["alpha", "nested", "root"],
)
def test_pull_request_scope_preserves_production_only_selection(self) -> None:
self.assertEqual(
selector.classify_clippy_scope(
["crates/alpha/src/lib.rs", "crates/alpha/tests/contract.rs"],
metadata(),
event="pull_request",
),
{"mode": "selected", "packages": ["alpha"]},
)
def test_merge_group_selects_changed_package_test_surfaces(self) -> None:
self.assertEqual(
selector.classify_clippy_scope(
[
"crates/alpha/tests/contract.rs",
"crates/alpha/benches/throughput.rs",
"crates/family/nested/examples/demo.rs",
],
metadata(),
event="merge_group",
),
{"mode": "selected", "packages": ["alpha", "nested"]},
)
def test_merge_group_production_changes_select_reverse_dependency_closure(
self,
) -> None:
self.assertEqual(
selector.classify_clippy_scope(
["crates/alpha/src/lib.rs"],
metadata(),
event="merge_group",
),
{"mode": "selected", "packages": ["alpha", "nested", "root"]},
)
def test_reverse_closure_uses_resolved_identity_for_renamed_dependency(
self,
) -> None:
self.assertEqual(
selector.classify_clippy_scope(
["crates/alpha/src/lib.rs"],
metadata_with_renamed_workspace_dependency(),
event="merge_group",
),
{"mode": "selected", "packages": ["alpha", "nested", "root"]},
)
def test_merge_group_test_surface_selects_only_owning_package(self) -> None:
self.assertEqual(
selector.classify_clippy_scope(
["crates/alpha/tests/contract.rs"],
metadata(),
event="merge_group",
),
{"mode": "selected", "packages": ["alpha"]},
)
def test_merge_group_global_inputs_escalate_to_full(self) -> None:
for path in (
"Cargo.toml",
"Cargo.lock",
"rust-toolchain.toml",
".cargo/config.toml",
".github/workflows/code_style.yml",
".github/actions/setup-rust/action.yml",
"scripts/ci/changed_workspace_packages.py",
):
with self.subTest(path=path):
self.assertEqual(
selector.classify_clippy_scope(
[path], metadata(), event="merge_group"
),
{"mode": "full", "packages": []},
)
def test_merge_group_workspace_member_manifests_escalate_to_full(self) -> None:
for path in (
"crates/alpha/Cargo.toml",
"crates/family/nested/Cargo.toml",
):
with self.subTest(path=path):
self.assertEqual(
selector.classify_clippy_scope(
[path], metadata(), event="merge_group"
),
{"mode": "full", "packages": []},
)
def test_merge_group_unknown_crate_path_escalates_to_full(self) -> None:
for path in ("crates/deleted/src/lib.rs", "Makefile"):
with self.subTest(path=path):
self.assertEqual(
selector.classify_clippy_scope(
[path], metadata(), event="merge_group"
),
{"mode": "full", "packages": []},
)
def test_empty_merge_group_diff_fails_fast(self) -> None:
with self.assertRaisesRegex(ValueError, "empty merge-group diff"):
selector.classify_clippy_scope([], metadata(), event="merge_group")
def test_non_code_diff_selects_no_clippy_scope(self) -> None:
for event in ("pull_request", "merge_group"):
with self.subTest(event=event):
self.assertEqual(
selector.classify_clippy_scope(
["docs/using/cli.mdx"], metadata(), event=event
),
{"mode": "none", "packages": []},
)
if __name__ == "__main__":
unittest.main()