From ed9c82fa3f7975c9fb8e88867bb216c73ff997d8 Mon Sep 17 00:00:00 2001 From: luzhuang <364439895@qq.com> Date: Thu, 6 Feb 2025 17:53:14 +0800 Subject: [PATCH] Fix audio test error in local env && Upgrade upload-artifact for e2e (#2539) * fix: upgrade upload-artifact * fix: audio test error in local env --- .github/workflows/ci.yml | 6 +++--- tests/src/core/audio/AudioSource.test.ts | 10 +++++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 796cb0fc9..0e218ea19 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -105,19 +105,19 @@ jobs: browser: chrome - name: Upload Diff if: failure() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: cypress-diff path: e2e/diff/ - name: Upload Origin if: failure() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: cypress-origin path: e2e/fixtures/originImage - name: Upload Screenshots if: failure() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: cypress-screenshots path: e2e/downloads/ diff --git a/tests/src/core/audio/AudioSource.test.ts b/tests/src/core/audio/AudioSource.test.ts index af85d2803..9699e988c 100644 --- a/tests/src/core/audio/AudioSource.test.ts +++ b/tests/src/core/audio/AudioSource.test.ts @@ -1,4 +1,4 @@ -import { AssetType, AudioClip, AudioSource, Engine } from "@galacean/engine-core"; +import { AssetType, AudioClip, AudioManager, AudioSource, Engine } from "@galacean/engine-core"; import "@galacean/engine-loader"; import { WebGLEngine } from "@galacean/engine-rhi-webgl"; import { beforeAll, describe, expect, it } from "vitest"; @@ -54,7 +54,11 @@ describe("AudioSource", () => { audioSource.stop(); audioSource.play(); - // Because the audio play should interaction - expect(audioSource.isPlaying).to.be.false; + if (AudioManager.isAudioContextRunning()) { + expect(audioSource.isPlaying).to.be.true; + } else { + // Because the audio play should interaction + expect(audioSource.isPlaying).to.be.false; + } }); });