From 4e1726e86dc8b7f428f07c029f2974e22bb04df9 Mon Sep 17 00:00:00 2001 From: xxnuo <54252779+xxnuo@users.noreply.github.com> Date: Sat, 10 Jan 2026 17:02:17 +0800 Subject: [PATCH] feat: rename maxLengthBreak to maxSentenceLength to prevent confusion Rename the variable names to prevent confusion. --- src/core/engine.ts | 11 +++++------ src/server/index.ts | 4 ++-- src/services/engine.ts | 2 +- ui/src/i18n/index.ts | 6 +++--- ui/src/lib/desktop.ts | 2 +- 5 files changed, 12 insertions(+), 13 deletions(-) diff --git a/src/core/engine.ts b/src/core/engine.ts index f0f8b83..ea4c896 100644 --- a/src/core/engine.ts +++ b/src/core/engine.ts @@ -44,7 +44,7 @@ export class TranslationEngine { private isReady = false; private translating = false; private pendingQueue: QueueTask[] = []; - private maxLengthBreak = 512; + private maxSentenceLength = 512; constructor(options: TranslationOptions = {}) { this.options = options; @@ -72,7 +72,6 @@ export class TranslationEngine { }; const mergedConfig = { ...defaultConfig, ...config }; - this.maxLengthBreak = mergedConfig['max-length-break'] || 512; const MODEL_FILE_ALIGNMENTS: Record = { model: 256, @@ -129,7 +128,7 @@ export class TranslationEngine { let translation: string; try { - if (cleanText.length > this.maxLengthBreak) { + if (cleanText.length > this.maxSentenceLength) { translation = this._translateLongText(cleanText, effectiveOptions); } else { translation = this._translateInternal(cleanText, effectiveOptions); @@ -260,20 +259,20 @@ export class TranslationEngine { bestParts = parts; } - if (maxLen <= this.maxLengthBreak) { + if (maxLen <= this.maxSentenceLength) { break; } } } if (bestParts.length <= 1) { - bestParts = this._chunkByWordBoundary(text, this.maxLengthBreak); + bestParts = this._chunkByWordBoundary(text, this.maxSentenceLength); bestSep = ""; } const results = bestParts.map(part => { if (!part.trim()) return part; - if (part.length > this.maxLengthBreak) { + if (part.length > this.maxSentenceLength) { return this._translateLongText(part, options); } return this._translateInternal(part, options); diff --git a/src/server/index.ts b/src/server/index.ts index 348b135..83ab94e 100644 --- a/src/server/index.ts +++ b/src/server/index.ts @@ -55,7 +55,7 @@ export async function startServer({ handleSignals = true } = {}) { logToFile: current.logToFile, logConsole: current.logConsole, logRequests: current.logRequests, - maxLengthBreak: current.maxLengthBreak, + maxSentenceLength: current.maxSentenceLength, checkUpdate: current.checkUpdate, cacheSize: current.cacheSize, modelDir: current.modelDir, @@ -94,7 +94,7 @@ export async function startServer({ handleSignals = true } = {}) { logToFile: toBool(input.logToFile, current.logToFile), logConsole: toBool(input.logConsole, current.logConsole), logRequests: toBool(input.logRequests, current.logRequests), - maxLengthBreak: toNumber(input.maxLengthBreak, current.maxLengthBreak), + maxSentenceLength: toNumber(input.maxSentenceLength, current.maxSentenceLength), checkUpdate: toBool(input.checkUpdate, current.checkUpdate), cacheSize: toNumber(input.cacheSize, current.cacheSize), modelDir: toString(input.modelDir, current.modelDir), diff --git a/src/services/engine.ts b/src/services/engine.ts index f002828..aa46ca5 100644 --- a/src/services/engine.ts +++ b/src/services/engine.ts @@ -251,7 +251,7 @@ export async function translateWithPivot( return text; } - if (text.length > config.maxLengthBreak && !isHTML) { + if (text.length > config.maxSentenceLength && !isHTML) { return translateLongText(effectiveFromLang, toLang, text); } diff --git a/ui/src/i18n/index.ts b/ui/src/i18n/index.ts index 2a81838..59d139e 100644 --- a/ui/src/i18n/index.ts +++ b/ui/src/i18n/index.ts @@ -90,7 +90,7 @@ const resources = { logDir: 'Log Directory', workerIdleTimeout: 'Worker Idle Timeout (s)', workersPerLanguage: 'Workers Per Language', - maxLengthBreak: 'Max Length Break', + maxSentenceLength: 'Max Length Break', cacheSize: 'Cache Size', logToFile: 'Log to File', logToFileDesc: 'Write logs to file', @@ -203,7 +203,7 @@ const resources = { logDir: '日志目录', workerIdleTimeout: '空闲超时(秒)', workersPerLanguage: '每语言工作数', - maxLengthBreak: '最大断句长度', + maxSentenceLength: '最大断句长度', cacheSize: '缓存大小', logToFile: '写入文件', logToFileDesc: '将日志写入文件', @@ -316,7 +316,7 @@ const resources = { logDir: 'ログディレクトリ', workerIdleTimeout: 'アイドルタイムアウト(秒)', workersPerLanguage: '言語ごとのワーカー数', - maxLengthBreak: '最大分割長', + maxSentenceLength: '最大分割長', cacheSize: 'キャッシュサイズ', logToFile: 'ファイルに記録', logToFileDesc: 'ログをファイルに書き込む', diff --git a/ui/src/lib/desktop.ts b/ui/src/lib/desktop.ts index a02fd59..24c8eb9 100644 --- a/ui/src/lib/desktop.ts +++ b/ui/src/lib/desktop.ts @@ -11,7 +11,7 @@ export type DesktopServerConfig = { logToFile: boolean logConsole: boolean logRequests: boolean - maxLengthBreak: number + maxSentenceLength: number checkUpdate: boolean cacheSize: number modelDir: string