From 1f7c58f7ce11b0119c35aebec907d6db3fe70e53 Mon Sep 17 00:00:00 2001 From: taetaetae Date: Tue, 3 Feb 2026 07:10:38 +0900 Subject: [PATCH] refactor: use constants for default assistant messages Apply code review feedback from gemini-code-assist: - Define default messages as local constants to improve maintainability - Avoid magic strings in the empty content handling logic --- internal/translator/kiro/openai/kiro_openai_request.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/internal/translator/kiro/openai/kiro_openai_request.go b/internal/translator/kiro/openai/kiro_openai_request.go index a621eebc..9c1eb895 100644 --- a/internal/translator/kiro/openai/kiro_openai_request.go +++ b/internal/translator/kiro/openai/kiro_openai_request.go @@ -695,10 +695,13 @@ func buildAssistantMessageFromOpenAI(msg gjson.Result) KiroAssistantResponseMess // This can happen with compaction requests or error recovery scenarios finalContent := contentBuilder.String() if strings.TrimSpace(finalContent) == "" { + const defaultAssistantContentWithTools = "I'll help you with that." + const defaultAssistantContent = "I understand." + if len(toolUses) > 0 { - finalContent = "I'll help you with that." + finalContent = defaultAssistantContentWithTools } else { - finalContent = "I understand." + finalContent = defaultAssistantContent } log.Debugf("kiro-openai: assistant content was empty, using default: %s", finalContent) }