From ad09c779989e4b407828d2ba8aaeb07092d44cdb Mon Sep 17 00:00:00 2001 From: Luis Pater Date: Thu, 22 Oct 2026 20:02:56 +0800 Subject: [PATCH] test(translator): skip replay target model allocation budget test under race detector - Add race and non-race build-tagged test files in the Codex Claude translator package to expose race detector status. - Skip TestConvertClaudeRequestToCodex_ResolvesReplayTargetModelOncePerRequest when the race detector is enabled to avoid flaky failures from random sync.Pool drops. Closes: #6872 --- .../translator/codex/claude/codex_claude_request_test.go | 4 ++++ internal/translator/codex/claude/race_disabled_test.go | 5 +++++ internal/translator/codex/claude/race_enabled_test.go | 5 +++++ 3 files changed, 14 insertions(+) create mode 100644 internal/translator/codex/claude/race_disabled_test.go create mode 100644 internal/translator/codex/claude/race_enabled_test.go diff --git a/internal/translator/codex/claude/codex_claude_request_test.go b/internal/translator/codex/claude/codex_claude_request_test.go index 4d4ba4acc..cbe9d0f6d 100644 --- a/internal/translator/codex/claude/codex_claude_request_test.go +++ b/internal/translator/codex/claude/codex_claude_request_test.go @@ -792,6 +792,10 @@ func TestConvertClaudeRequestToCodex_AssistantRoutedMetaSignatureToReasoningItem } func TestConvertClaudeRequestToCodex_ResolvesReplayTargetModelOncePerRequest(t *testing.T) { + if raceDetectorEnabled { + t.Skip("allocation budgets are not meaningful with race detector instrumentation") + } + const thinkingBlocks = 64 var body strings.Builder body.WriteString(`{"messages":[{"role":"assistant","content":[`) diff --git a/internal/translator/codex/claude/race_disabled_test.go b/internal/translator/codex/claude/race_disabled_test.go new file mode 100644 index 000000000..f72c545a3 --- /dev/null +++ b/internal/translator/codex/claude/race_disabled_test.go @@ -0,0 +1,5 @@ +//go:build !race + +package claude + +const raceDetectorEnabled = false diff --git a/internal/translator/codex/claude/race_enabled_test.go b/internal/translator/codex/claude/race_enabled_test.go new file mode 100644 index 000000000..6fe7331c7 --- /dev/null +++ b/internal/translator/codex/claude/race_enabled_test.go @@ -0,0 +1,5 @@ +//go:build race + +package claude + +const raceDetectorEnabled = true